Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15120#discussion_r79895411
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -383,8 +383,9 @@ class SparkContext(config: SparkConf) extends Logging 
with ExecutorAllocationCli
           logInfo("Spark configuration:\n" + _conf.toDebugString)
         }
     
    -    // Set Spark driver host and port system properties
    -    _conf.setIfMissing("spark.driver.host", Utils.localHostName())
    +    // Set Spark driver host and port system properties. This explicitly 
sets the configuration
    +    // instead of relying on the default value of the config constant.
    +    _conf.set(DRIVER_HOST_ADDRESS, conf.get(DRIVER_HOST_ADDRESS))
    --- End diff --
    
    nit: could you use `_conf` instead? I thought `_conf` and `conf` were 
different at first glance. But actually they are same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to