Github user jiangxb1987 commented on a diff in the pull request:
    --- Diff: 
    @@ -170,11 +170,9 @@ class ArithmeticExpressionSuite extends SparkFunSuite 
with ExpressionEvalHelper
         checkEvaluation(Remainder(positiveLongLit, positiveLongLit), 0L)
         checkEvaluation(Remainder(negativeLongLit, negativeLongLit), 0L)
    -    // TODO: the following lines would fail the test due to inconsistency 
result of interpret
    --- End diff --
    The result of interpret and codegen for remainder between giant values are 
equal within relative tolerance, so maybe this no longer requires to be 
resolved. Thanks!

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to