Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15059#discussion_r79779543
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala
 ---
    @@ -170,11 +170,9 @@ class ArithmeticExpressionSuite extends SparkFunSuite 
with ExpressionEvalHelper
         checkEvaluation(Remainder(positiveLongLit, positiveLongLit), 0L)
         checkEvaluation(Remainder(negativeLongLit, negativeLongLit), 0L)
     
    -    // TODO: the following lines would fail the test due to inconsistency 
result of interpret
    --- End diff --
    
    Ah, it seemed worth removing because the change does apparently make this 
test pass, and that's what the comment refers to. If it's still an issue, we 
can restore a modified version of the comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to