Github user frreiss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15005#discussion_r79766509
  
    --- Diff: docs/building-spark.md ---
    @@ -16,24 +16,27 @@ Building Spark using Maven requires Maven 3.3.9 or 
newer and Java 7+.
     
     ### Setting up Maven's Memory Usage
     
    -You'll need to configure Maven to use more memory than usual by setting 
`MAVEN_OPTS`. We recommend the following settings:
    +If you are compiling with Java 7, you'll need to configure Maven to use 
more memory than usual by setting `MAVEN_OPTS`:
    --- End diff --
    
    Leaving out `-XX:ReservedCodeCacheSize` caused a warning in my tests:
    ```OpenJDK 64-Bit Server VM warning: CodeCache is full. Compiler has been 
disabled.
    OpenJDK 64-Bit Server VM warning: Try increasing the code cache size using 
-XX:ReservedCodeCacheSize=```
    Left that option in and reworded the beginning of this section as you 
suggested.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to