Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15005#discussion_r79778787
  
    --- Diff: docs/building-spark.md ---
    @@ -16,24 +16,32 @@ Building Spark using Maven requires Maven 3.3.9 or 
newer and Java 7+.
     
     ### Setting up Maven's Memory Usage
     
    -You'll need to configure Maven to use more memory than usual by setting 
`MAVEN_OPTS`. We recommend the following settings:
    +You'll need to configure Maven to use more memory than usual by setting 
`MAVEN_OPTS`:
     
    -    export MAVEN_OPTS="-Xmx2g -XX:MaxPermSize=512M 
-XX:ReservedCodeCacheSize=512m"
    +    export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=512m"
     
    -If you don't run this, you may see errors like the following:
    +When compiling with Java 7, you will need to add the additional option 
"-XX:MaxPermSize=512M" to MAVEN_OPTS.
    +
    +If you don't add these parameters to `MAVEN_OPTS`, you may see errors and 
warnings like the following:
     
         [INFO] Compiling 203 Scala sources and 9 Java sources to 
/Users/me/Development/spark/core/target/scala-{{site.SCALA_BINARY_VERSION}}/classes...
         [ERROR] PermGen space -> [Help 1]
     
         [INFO] Compiling 203 Scala sources and 9 Java sources to 
/Users/me/Development/spark/core/target/scala-{{site.SCALA_BINARY_VERSION}}/classes...
         [ERROR] Java heap space -> [Help 1]
     
    -You can fix this by setting the `MAVEN_OPTS` variable as discussed before.
    +    [INFO] Compiling 233 Scala sources and 41 Java sources to 
/Users/me/Development/spark/sql/core/target/scala-{site.SCALA_BINARY_VERSION}/classes...
    +    OpenJDK 64-Bit Server VM warning: CodeCache is full. Compiler has been 
disabled.
    +    OpenJDK 64-Bit Server VM warning: Try increasing the code cache size 
using -XX:ReservedCodeCacheSize=
    +
    +You can fix these problems by setting the `MAVEN_OPTS` variable as 
discussed before.
     
     **Note:**
     
    -* For Java 8 and above this step is not required.
    -* If using `build/mvn` with no `MAVEN_OPTS` set, the script will automate 
this for you.
    +* If using `build/mvn` with no `MAVEN_OPTS` set, the script will 
automatically add the above options for Java 7 to the `MAVEN_OPTS` environment 
variable.
    --- End diff --
    
    It actually adds them regardless of the Java version, it seems. Which is 
fine. The rest looks good. If you get to that change, great, otherwise I can 
probably safely make the change on merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to