Github user mattf commented on the pull request:
https://github.com/apache/spark/pull/2093#issuecomment-53190051
i'm never a fan of code reformatting, whitespace changes or refactoring at
the same time as functional changes, e.g. if (k, v) => if k, v; v if k not in m
else func(m[k], v) => func(m[k], v) if k in m else v; MaxHeapQ; if not x:
return None -> if x: return y
while all those are good changes, it's good practice (and future you me and
others will thank you) to bundle those changes w/ their own justification, for
instance -
question: why did you change to using count() instead of collect() to force
evaluation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
