Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2093#issuecomment-53306345
@mattf I agree with you that it's generally a good idea to separate
functional vs. cosmetic changes (I've weighed in against several PRs that
_only_ perform minor code formatting changes, especially ones that touch tens
or hundreds of files).
Ideally, this PR would have only made the necessary changes for `lookup()`,
since that makes things easier to review. However, I think we do want to
eventually make most of the other changes, so I don't mind trying to review
those changes here (the alternative is having to review another PR, which
creates more work for me now that I've already reviewed the code here).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
