Github user sarutak commented on the pull request:

    https://github.com/apache/spark/pull/2019#issuecomment-53192139
  
    One of issues I'd like to resolve in this PR is miss-detection when 
SedingConnection is closed by corresponding ReceivingConnection in 
removeConnection.
    If SendingConnection close itself, invoking removeConnection then, 
corresponding ReceivingConnection fail to close the SendingConnection because 
sendingConnectionOpt.isDefined is false.
    
    
              if (!sendingConnectionOpt.isDefined) {
                logError(s"Corresponding SendingConnection to 
${remoteConnectionManagerId} not found")
                return
              }
    
    Actually, this situation is not error.
    
    Can we remove the logic for closing SendingConnection? It's expected be 
closed by itself or ConnectionManager#stop right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to