Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15149#discussion_r79851244
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala 
---
    @@ -50,9 +50,9 @@ private[shared] object SharedParamsCodeGen {
             isValid = "ParamValidators.inRange(0, 1)", finalMethods = false),
           ParamDesc[Array[Double]]("thresholds", "Thresholds in multi-class 
classification" +
             " to adjust the probability of predicting each class." +
    -        " Array must have length equal to the number of classes, with 
values >= 0." +
    +        " Array must have length equal to the number of classes, with 
values > 0." +
             " The class with largest value p/t is predicted, where p is the 
original probability" +
    -        " of that class and t is the class' threshold",
    +        " of that class and t is the class's threshold",
             isValid = "(t: Array[Double]) => t.forall(_ >= 0)", finalMethods = 
false),
    --- End diff --
    
    This line doesn't line up with what is in `sharedParams.scala`. This file 
_should_ generate `sharedParams.scala` via `build/sbt "mllib/runMain 
org.apache.spark.ml.param.shared.SharedParamsCodeGen"`. `t.forall(_ >= 0)` 
Should be `t.forall(_ > 0)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to