Github user holdenk commented on the issue:

    https://github.com/apache/spark/pull/15149
  
    This looks really reasonable, the only catch is that the thresholds can be 
effectively set through `setThreshold` as well as `setThresholds`.
    
    So we probably also want to update the range notation used in 
`setThreshold` (since right now its listed valid thresholds as `[0, 1]` and 0 
is no longer valid we probably want to swap it to `(0, 1)`
    As well we probably want to change the validator used for threshold to 
exclude 0 in SharedParamsCodeGen.scala
    
    We should also probably add a test for this as well since it almost went in 
without this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to