Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15168#discussion_r79947817
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
    @@ -276,13 +276,19 @@ class SparkSqlAstBuilder(conf: SQLConf) extends 
AstBuilder {
        * Create a [[DescribeTableCommand]] logical plan.
        */
       override def visitDescribeTable(ctx: DescribeTableContext): LogicalPlan 
= withOrigin(ctx) {
    -    // Describe partition and column are not supported yet. Return null 
and let the parser decide
    +    // Describe column are not supported yet. Return null and let the 
parser decide
         // what to do with this (create an exception or pass it on to a 
different system).
    -    if (ctx.describeColName != null || ctx.partitionSpec != null) {
    +    if (ctx.describeColName != null) {
           null
         } else {
    +      val partitionSpec = if (ctx.partitionSpec != null) {
    +        visitPartitionSpec(ctx.partitionSpec).filter(_._2.isDefined).map(x 
=> (x._1, x._2.get))
    --- End diff --
    
    Could you collect here and add some names? It is a bit cryptic at the 
moment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to