Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15190#discussion_r79978495
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
    @@ -988,9 +988,7 @@ class SparkSqlAstBuilder(conf: SQLConf) extends 
AstBuilder {
               .orElse(Some("org.apache.hadoop.mapred.TextInputFormat")),
             outputFormat = defaultHiveSerde.flatMap(_.outputFormat)
               
.orElse(Some("org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat")),
    -        // Note: Keep this unspecified because we use the presence of the 
serde to decide
    --- End diff --
    
    The current checking conditions are based on [ctx.createFileFormat and 
ctx.rowFormat](https://github.com/dilipbiswal/spark/blob/f2b93de629f378ca99f8d3086ade8dc05b41a912/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala#L1051-L1052).
 Thus, I think this PR looks ok. : )
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to