Github user dilipbiswal commented on a diff in the pull request:
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
    @@ -988,9 +988,7 @@ class SparkSqlAstBuilder(conf: SQLConf) extends 
AstBuilder {
             outputFormat = defaultHiveSerde.flatMap(_.outputFormat)
    -        // Note: Keep this unspecified because we use the presence of the 
serde to decide
    --- End diff --
    @viirya @cloud-fan Actually i am not sure, if the above comment is in sync 
with the code. When we had this comment, we used to have 
CreateTableAsSelectLogicalPlan to represent the CTAS case and we used to check 
for serde's presence to determine whether or not to convert it to a data source 
table like following.
    ``` SQL
       if (sessionState.convertCTAS && {
              // Do the conversion when spark.sql.hive.convertCTAS is true and 
the query
              // does not specify any storage format (file format and storage 
              if (table.identifier.database.isDefined) {
                throw new AnalysisException(
                  "Cannot specify database name in a CTAS statement " +
                    "when spark.sql.hive.convertCTAS is set to true.")
              val mode = if (allowExisting) SaveMode.Ignore else 
                temporary = false,
                bucketSpec = None,
                options = Map.empty[String, String],
            } else {
              val desc = if ( {
                // add default serde
                  serde = 
              } else {
    I think this code has changed and moved to SparkSqlParser ?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to