Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r80407704
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -60,20 +90,21 @@ case class CreateViewCommand(
child: LogicalPlan,
allowExisting: Boolean,
replace: Boolean,
- isTemporary: Boolean)
+ viewType: ViewType)
extends RunnableCommand {
override protected def innerChildren: Seq[QueryPlan[_]] = Seq(child)
- if (!isTemporary) {
- require(originalText.isDefined,
- "The table to created with CREATE VIEW must have 'originalText'.")
+ if (viewType == PermanentView) {
+ require(originalText.isDefined, "'originalText' must be provided to
create permanent view")
}
if (allowExisting && replace) {
throw new AnalysisException("CREATE VIEW with both IF NOT EXISTS and
REPLACE is not allowed.")
}
+ private def isTemporary = viewType == LocalTempView || viewType ==
GlobalTempView
+
--- End diff --
it's only used here, maybe it's OK?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
