Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15231#discussion_r80536437
--- Diff: R/pkg/R/utils.R ---
@@ -698,6 +698,21 @@ isSparkRShell <- function() {
grepl(".*shell\\.R$", Sys.getenv("R_PROFILE_USER"), perl = TRUE)
}
+captureJVMException <- function(e) {
+ stacktrace <- as.character(e)
+ if (any(grep("java.lang.IllegalArgumentException: ", stacktrace))) {
--- End diff --
I agree, I don't think we should couple the R code to the underlining data
source implementations, and was not suggesting that :)
I guess I'm saying there are still many (other) cases where the parameters
are unchecked and would be good if this check to convert JVM
IllegalArgumentException is sufficient or more checks should be added to the R
side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
