Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15231#discussion_r80596168
--- Diff: R/pkg/R/utils.R ---
@@ -698,6 +698,21 @@ isSparkRShell <- function() {
grepl(".*shell\\.R$", Sys.getenv("R_PROFILE_USER"), perl = TRUE)
}
+captureJVMException <- function(e) {
+ stacktrace <- as.character(e)
+ if (any(grep("java.lang.IllegalArgumentException: ", stacktrace))) {
--- End diff --
great, thanks - generally I'd prefer having parameter checks in R; though
in this case I think we need balance the added code complicity and reduced
usability (by checking more, it might fail where it didn't before).
so I'm not 100% sure we should add parameter checks all across the board.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
