Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15245#discussion_r80567861
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/RecordReaderIterator.scala
 ---
    @@ -38,7 +41,7 @@ class RecordReaderIterator[T](rowReader: RecordReader[_, 
T]) extends Iterator[T]
             // Close and release the reader here; close() will also be called 
when the task
             // completes, but for tasks that read from many files, it helps to 
release the
             // resources early.
    -        rowReader.close()
    --- End diff --
    
    This is `CompletionIterator`-style cleanup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to