Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15245#discussion_r80568112
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/RecordReaderIterator.scala
---
@@ -27,7 +29,8 @@ import org.apache.spark.sql.catalyst.InternalRow
* Note that this returns [[Object]]s instead of [[InternalRow]] because
we rely on erasure to pass
* column batches by pretending they are rows.
*/
-class RecordReaderIterator[T](rowReader: RecordReader[_, T]) extends
Iterator[T] {
+class RecordReaderIterator[T](
+ private[this] var rowReader: RecordReader[_, T]) extends Iterator[T]
with Closeable {
--- End diff --
By nulling out the `rowReader` I think that this will prevent memory
consumption from becoming too high in the list of task completion callbacks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
