Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15307#discussion_r81629084
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -273,8 +304,14 @@ class StreamExecution(
val hasNewData = {
awaitBatchLock.lock()
try {
- val newData = uniqueSources.flatMap(s => s.getOffset.map(o => s ->
o))
- availableOffsets ++= newData
+ timeIt(GET_OFFSET_LATENCY) {
+ val latestOffsets: Map[Source, Option[Offset]] =
uniqueSources.map { s =>
+ timeIt(s, SOURCE_GET_OFFSET_LATENCY) {
+ (s, s.getOffset)
+ }
+ }.toMap
+ availableOffsets ++= latestOffsets.filter { case (s, o) =>
o.nonEmpty }.mapValues(_.get)
--- End diff --
I just converted `flatMap over Options` to `filter out Nones and then get`.
It seemed marginally more easy to understand than the flatmap, but I am willing
to change it back if this is more confusing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
