Github user frreiss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15307#discussion_r81668841
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulAggregate.scala
 ---
    @@ -56,7 +57,12 @@ case class StateStoreRestoreExec(
         child: SparkPlan)
       extends execution.UnaryExecNode with StatefulOperator {
     
    +  override lazy val metrics = Map(
    +    "numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of 
output rows"))
    --- End diff --
    
    The metric names should probably be in a separate, centralized list of 
constants. Users will want a single place in the API docs to find a list of all 
available metrics, and the list is likely to change quite frequently as 
Structured Streaming evolves.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to