Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15292#discussion_r81655584
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
 ---
    @@ -17,13 +17,28 @@
     
     package org.apache.spark.sql.execution.datasources.jdbc
     
    +import java.sql.Connection
    +import java.util.Properties
    +
     /**
      * Options for the JDBC data source.
      */
     class JDBCOptions(
         @transient private val parameters: Map[String, String])
       extends Serializable {
     
    +  import JDBCOptions._
    +
    +  def this(url: String, table: String, parameters: Map[String, String]) = {
    +    this(parameters ++ Map("url" -> url, "dbtable" -> table))
    +  }
    +
    +  val asProperties: Properties = {
    +    val properties = new Properties()
    +    parameters.foreach { case (k, v) => properties.setProperty(k, v) }
    --- End diff --
    
    We should exclude `url` and `dbtable` here. Otherwise, we will pass them to 
the `connect` call of JDBC driver.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to