Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15292#discussion_r81737474
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -35,7 +50,12 @@ class JDBCOptions(
val table = parameters("dbtable")
// ------------------------------------------------------------
- // Optional parameter list
+ // Optional parameters
+ // ------------------------------------------------------------
+ val driver = parameters.get(JDBCOptions.JDBC_DRIVER_CLASS)
--- End diff --
I do favour to keep the validation logics and options within `JDBCOptions`
if you don't strongly feel about moving it into
`JdbcUtils.createConnectionFactory`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
