Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15246#discussion_r82150814
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -41,6 +43,15 @@ abstract class SparkFunSuite
}
}
+ // helper function
+ protected final def getFile(file: String): File = {
--- End diff --
I like what you've done here with `getCanonicalPath`. Does this call here
need `getCanonicalFile` for good measure? I supposes there's also something
like `Paths.get(... toURI).toFile` but I don't know if that acts any
differently.
How about calling these `getTestResourceFile` and `getTestResourcePath`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
