Github user weiqingy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15246#discussion_r82317563
  
    --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
    @@ -41,6 +43,15 @@ abstract class SparkFunSuite
         }
       }
     
    +  // helper function
    +  protected final def getFile(file: String): File = {
    --- End diff --
    
    @srowen getTestResourceFile and getTestResourcePath look better. Thanks.
    
    URL class doesn't have a method like getCanonicalFile. It has getFile only.
    
    Also, I tested  Paths.get(... toURI).toFile. The only difference I noticed 
is that it keeps spaces as usual, but getFile(file).getCanonicalPath converts 
spaces to "%20". I suppose they are both OK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to