Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82503897
--- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/BLAS.scala
---
@@ -244,6 +244,15 @@ private[spark] object BLAS extends Serializable {
}
/**
+ * y += alpha * A * x
+ *
+ * @param A The upper triangular part of A in a [[DenseVector]] (column
major)
+ */
+ def dspmv(n: Int, alpha: Double, A: DenseVector, x: DenseVector, y:
DenseVector): Unit = {
--- End diff --
Actually BLAS DSPMV performs matrix-vector operation ```y := alpha*A*x +
beta*y```, should we provide the same function as original BLAS? Since it would
be used by other MLlib function in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
