Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82503779
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -217,7 +215,7 @@ class LinearRegression @Since("1.3.0") (@Since("1.3.0")
override val uid: String
$(featuresCol),
summaryModel,
model.diagInvAtWA.toArray,
- Array(0D))
+ model.objectiveHistory)
--- End diff --
I think the ```objectiveHistory``` get from normal equation solver is
different from distributed L-BFGS solver, so it may confuse users. We should
handle ```objectiveHistory``` differently when we use it(I saw only used in
linear regression summary), or may be just better documents?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
