Github user mallman commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14690#discussion_r82712965
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
 ---
    @@ -477,6 +478,15 @@ class InMemoryCatalog(
         catalog(db).tables(table).partitions.values.toSeq
       }
     
    +  override def listPartitionsByFilter(
    +      db: String,
    +      table: String,
    +      predicates: Seq[Expression]): Seq[CatalogTablePartition] = {
    +    // TODO: Provide an implementation
    +    throw new UnsupportedOperationException(
    +      "listPartitionsByFilter is not implemented")
    --- End diff --
    
    It isn't? In the spirit of the principle of least surprise, my intention 
for this method was that it return exactly the partitions matching the given 
predicates.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to