Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14690#discussion_r82875191
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala 
---
    @@ -225,13 +225,16 @@ case class FileSourceScanExec(
       }
     
       // These metadata values make scan plans uniquely identifiable for 
equality checking.
    -  override val metadata: Map[String, String] = Map(
    -    "Format" -> relation.fileFormat.toString,
    -    "ReadSchema" -> outputSchema.catalogString,
    -    "Batched" -> supportsBatch.toString,
    -    "PartitionFilters" -> partitionFilters.mkString("[", ", ", "]"),
    -    "PushedFilters" -> dataFilters.mkString("[", ", ", "]"),
    -    "InputPaths" -> relation.location.paths.mkString(", "))
    +  override val metadata: Map[String, String] = {
    +    def seqToString(seq: Seq[Any]) = seq.mkString("[", ", ", "]")
    +    val location = relation.location
    +    Map("Format" -> relation.fileFormat.toString,
    +      "ReadSchema" -> outputSchema.catalogString,
    +      "Batched" -> supportsBatch.toString,
    +      "PartitionFilters" -> seqToString(partitionFilters),
    +      "PushedFilters" -> seqToString(dataFilters),
    +      "Location" -> (location.getClass.getSimpleName + 
seqToString(location.rootPaths)))
    --- End diff --
    
    Is it different from location.getRootPaths.length? I guess that would only 
be meaningful for Hive-backed tables, but that seems ok.
    
    Btw, you might want to take(10) on the root paths to avoid materializing a 
large string here before it gets truncated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to