Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15307#discussion_r83083859
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQuerySuite.scala
 ---
    @@ -17,22 +17,78 @@
     
     package org.apache.spark.sql.streaming
     
    +import java.io.File
    +
    +import org.scalactic.TolerantNumerics
    +import org.scalatest.concurrent.Eventually._
     import org.scalatest.BeforeAndAfter
     
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.sql.DataFrame
    +import org.apache.spark.sql.catalyst.util._
    +import org.apache.spark.sql.internal.SQLConf
    +import org.apache.spark.sql.streaming.StreamingQueryListener._
    +import org.apache.spark.sql.types.StructType
     import org.apache.spark.SparkException
    -import org.apache.spark.sql.execution.streaming.{CompositeOffset, 
LongOffset, MemoryStream, StreamExecution}
    +import org.apache.spark.sql.execution.streaming._
     import org.apache.spark.util.Utils
     
     
    -class StreamingQuerySuite extends StreamTest with BeforeAndAfter {
    +class StreamingQuerySuite extends StreamTest with BeforeAndAfter with 
Logging {
     
       import AwaitTerminationTester._
       import testImplicits._
     
    +  // To make === between double tolerate inexact values
    +  implicit val doubleEquality = 
TolerantNumerics.tolerantDoubleEquality(0.01)
    +
       after {
         sqlContext.streams.active.foreach(_.stop())
       }
     
    +  abstract class AddFileData extends AddData {
    --- End diff --
    
    Only one child class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to