Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15307#discussion_r83079220
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
 ---
    @@ -351,25 +403,26 @@ class StreamExecution(
     
         // Rewire the plan to use the new attributes that were returned by the 
source.
         val replacementMap = AttributeMap(replacements)
    -    val newPlan = withNewSources transformAllExpressions {
    +    val triggerLogicalPlan = withNewSources transformAllExpressions {
           case a: Attribute if replacementMap.contains(a) => replacementMap(a)
         }
     
         val optimizerStart = System.nanoTime()
         lastExecution = new IncrementalExecution(
           sparkSession,
    -      newPlan,
    +      triggerLogicalPlan,
           outputMode,
           checkpointFile("state"),
           currentBatchId)
     
    -    lastExecution.executedPlan
    +    val executedPlan = lastExecution.executedPlan // Force the lazy 
generation of execution plan
         val optimizerTime = (System.nanoTime() - optimizerStart).toDouble / 
1000000
    --- End diff --
    
    Should this be reported using metrics rather than logging now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to