Github user marmbrus commented on a diff in the pull request:
    --- Diff: 
    @@ -0,0 +1,240 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.sql.execution.streaming
    +import java.{util => ju}
    +import scala.collection.mutable
    +import com.codahale.metrics.{Gauge, MetricRegistry}
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.metrics.source.{Source => CodahaleSource}
    +import org.apache.spark.util.Clock
    + * Class that manages all the metrics related to a StreamingQuery. It does 
the following.
    + * - Calculates metrics (rates, latencies, etc.) based on information 
reported by StreamExecution.
    + * - Allows the current metric values to be queried
    + * - Serves some of the metrics through Codahale/DropWizard metrics
    --- End diff --
    Sorry, I think its reasonable to put the metrics in a separate class since 
there is a lot of code there (though some of the methods are in StreamExecution 
and I was a little unclear on why).  I'm asking why this also handles the 
Codahale metrics.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to