Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11105#discussion_r83271147
  
    --- Diff: core/src/main/scala/org/apache/spark/Accumulable.scala ---
    @@ -56,15 +61,26 @@ class Accumulable[R, T] private (
         @transient private val initialValue: R,
         param: AccumulableParam[R, T],
         val name: Option[String],
    -    private[spark] val countFailedValues: Boolean)
    +    private[spark] val countFailedValues: Boolean,
    +    private[spark] val dataProperty: Boolean)
       extends Serializable {
     
       private[spark] def this(
           initialValue: R,
           param: AccumulableParam[R, T],
           name: Option[String],
    +      countFailedValues: Boolean,
    +      dataProperty: Boolean) = {
    +    this(AccumulatorContext.newId(), initialValue, param, name, 
countFailedValues, dataProperty)
    +  }
    +
    +  private[spark] def this(
    +      initialValue: R,
    +      param: AccumulableParam[R, T],
    +      name: Option[String],
           countFailedValues: Boolean) = {
    -    this(AccumulatorContext.newId(), initialValue, param, name, 
countFailedValues)
    +    this(AccumulatorContext.newId(), initialValue, param, name, 
countFailedValues,
    +      false /* dataProperty */)
    --- End diff --
    
    `dataProperty = false`
    
    (though as I mentioned elsewhere, I think you shouldn't have this option on 
the old api)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to