Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11105#discussion_r83287789
  
    --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
    @@ -722,6 +722,7 @@ private[spark] object JsonProtocol {
         val value = Utils.jsonOption(json \ "Value").map { v => 
accumValueFromJson(name, v) }
         val internal = (json \ "Internal").extractOpt[Boolean].getOrElse(false)
         val countFailedValues = (json \ "Count Failed 
Values").extractOpt[Boolean].getOrElse(false)
    +    val dataProperty = (json \ 
"DataProperty").extractOpt[Boolean].getOrElse(false)
    --- End diff --
    
    can you add a test case to the backwards compatability section in 
`JsonProtocolSuite`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to