Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2157#discussion_r16765443
--- Diff: sql/hive/src/main/scala/org/apache/spark/SparkHadoopWriter.scala
---
@@ -71,7 +71,7 @@ private[hive] class SparkHiveHadoopWriter(
}
def open() {
- val numfmt = NumberFormat.getInstance()
+ val numfmt = SparkHiveHadoopWriter.threadLocalNumberFormat.get()
--- End diff --
This is a local variable, right? It's not shared with other threads. It is
already creating a new instance for each call. Or if you argue it could be the
same instance -- a `ThreadLocal` wouldn't help. But it really can't be a
singleton.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
