Github user avulanov commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15382#discussion_r83478546
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -757,7 +758,10 @@ private[sql] class SQLConf extends Serializable with 
CatalystConf with Logging {
     
       def variableSubstituteDepth: Int = getConf(VARIABLE_SUBSTITUTE_DEPTH)
     
    -  def warehousePath: String = new Path(getConf(WAREHOUSE_PATH)).toString
    +  def warehousePath: String = {
    +    val path = new Path(getConf(WAREHOUSE_PATH))
    +    FileSystem.get(path.toUri, new 
Configuration()).makeQualified(path).toString
    --- End diff --
    
    I mean fixing the behavior because it is incorrect. We cannot use this 
function in its present state, it will introduce more issues. This seems to be 
a part of a bigger issue that paths in Spark are processed in many different 
ways that are not consistent. Here few examples: 
https://github.com/apache/spark/pull/12695#issuecomment-237824442, 
https://github.com/apache/spark/pull/13868#issuecomment-228932793



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to