Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11119#discussion_r83579235
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala 
---
    @@ -241,6 +252,12 @@ object KMeansModel extends MLReadable[KMeansModel] {
           }
           val model = new KMeansModel(metadata.uid, new 
MLlibKMeansModel(clusterCenters))
           DefaultParamsReader.getAndSetParams(model, metadata)
    +      DefaultParamsReader.loadInitialModel[KMeansModel](path, sc) match {
    --- End diff --
    
    minor: If we are going to use a pattern match here, let's use it in the 
`KMeansReader` too. I think either is fine, but let's use a single convention. 
Also, if you eliminate the pattern match entirely, then the imports for Success 
and Failure can be removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to