Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11119#discussion_r83694228
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala 
---
    @@ -303,6 +312,20 @@ class KMeans @Since("1.5.0") (
       @Since("1.5.0")
       def setSeed(value: Long): this.type = set(seed, value)
     
    +  /** @group setParam */
    --- End diff --
    
    I don't feel really strongly about it. But I think it is not a critical 
failure, so does not really require a hard stop of an exception. Since we make 
it clear in the doc that initial model `k` takes precedence, if a user sets a 
different `k` anyway we can still proceed, just let them know that we are 
ignoring their setting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to