Github user mateiz commented on a diff in the pull request:
    --- Diff: 
core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala ---
    @@ -75,9 +75,11 @@ class KryoSerializerSuite extends SparkFunSuite with 
SharedSparkContext {
       test("basic types") {
    -    val ser = new KryoSerializer(conf).newInstance()
         def check[T: ClassTag](t: T) {
    -      assert(ser.deserialize[T](ser.serialize(t)) === t)
    +      testBothUnsafeAndSafe(conf) { sparkConf =>
    --- End diff --
    Is there any way to refactor this into two Suites, where one extends from 
the other and has additional setup code (or a setup method that it overrides)? 
Otherwise we have to remember to add this construct to all tests.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to