Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12913#discussion_r83972911
  
    --- Diff: 
core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala ---
    @@ -75,9 +75,11 @@ class KryoSerializerSuite extends SparkFunSuite with 
SharedSparkContext {
       }
     
       test("basic types") {
    -    val ser = new KryoSerializer(conf).newInstance()
         def check[T: ClassTag](t: T) {
    -      assert(ser.deserialize[T](ser.serialize(t)) === t)
    +      testBothUnsafeAndSafe(conf) { sparkConf =>
    --- End diff --
    
    (We have a few other examples suites where we just inherit from existing 
suites, such as SortShuffleSuite vs ShuffleSuite.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to