Github user hvanhovell commented on a diff in the pull request:
    --- Diff: 
    @@ -142,319 +84,37 @@ case class HyperLogLogPlusPlus(
       override def inputTypes: Seq[AbstractDataType] = Seq(AnyDataType)
    -  override def aggBufferSchema: StructType = 
    -  /** Allocate enough words to store all registers. */
    -  override val aggBufferAttributes: Seq[AttributeReference] = 
Seq.tabulate(numWords) { i =>
    -    AttributeReference(s"MS[$i]", LongType)()
    +  override def createAggregationBuffer(): HyperLogLogPlusPlusAlgo = {
    +    new HyperLogLogPlusPlusAlgo(relativeSD)
    --- End diff --
    This, by definition, moves HLL++ operator to the sort based aggregation 
path. This will be a huge performance hit. Is it possible to separate the 
algorithm from the buffer?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to