Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15544#discussion_r84006557
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala
 ---
    @@ -142,319 +84,37 @@ case class HyperLogLogPlusPlus(
     
       override def inputTypes: Seq[AbstractDataType] = Seq(AnyDataType)
     
    -  override def aggBufferSchema: StructType = 
StructType.fromAttributes(aggBufferAttributes)
    -
    -  /** Allocate enough words to store all registers. */
    -  override val aggBufferAttributes: Seq[AttributeReference] = 
Seq.tabulate(numWords) { i =>
    -    AttributeReference(s"MS[$i]", LongType)()
    +  override def createAggregationBuffer(): HyperLogLogPlusPlusAlgo = {
    +    new HyperLogLogPlusPlusAlgo(relativeSD)
    --- End diff --
    
    @hvanhovell Do you mean we should not use `TypedImperativeAggregate` 
instead of `ImperativeAggregate`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to