Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15556#discussion_r84492074
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -557,7 +560,8 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
*/
private def replay(
eventLog: FileStatus,
- bus: ReplayListenerBus): Option[FsApplicationAttemptInfo] = {
+ bus: ReplayListenerBus,
+ eventsFilter: ReplayEventsFilter = SELECT_ALL_FILTER):
Option[FsApplicationAttemptInfo] = {
--- End diff --
I think I agree, but then, the other call site actually uses the return
value of this method, but, also supplies a listener/bus to collect other info,
and then also parses that. It seems like this method could simply do all that
work for both callers and not even need an external bus?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
