Github user vijoshi commented on a diff in the pull request:
https://github.com/apache/spark/pull/15556#discussion_r84689281
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -557,7 +560,8 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
*/
private def replay(
eventLog: FileStatus,
- bus: ReplayListenerBus): Option[FsApplicationAttemptInfo] = {
+ bus: ReplayListenerBus,
+ eventsFilter: ReplayEventsFilter = SELECT_ALL_FILTER):
Option[FsApplicationAttemptInfo] = {
--- End diff --
This helper replay method will need to be supplied a listener bus
externally because the two call sites need very different sets of listeners on
the bus. Only thing it looked we could do was enrich the return value from the
helper to prevent the second callsite (getAppUI() ) from having to add and
parse from an additional listener of its own. I've pushed the updated commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
