Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15596#discussion_r84569163
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -39,7 +39,7 @@
protected int partitionIndex = -1;
public boolean hasNext() throws IOException {
- if (currentRows.isEmpty()) {
+ if (!shouldStop()) {
--- End diff --
`shouldStop` in whole stage codegen can be override to have custom stop
condition other than just `currentRows.isEmpty()`.
For example, in limit, we will stop iterator processing early if limitation
is met.
Without this change, this pr will fail one test in SQLQuerySuite:
"SPARK-17515: CollectLimit.execute() should perform per-partition limits".
Because the `LocalLimit` will not stop immediately but in next round after
reaching limitation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
