Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15596#discussion_r84569198
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -83,9 +83,8 @@ trait BaseLimitExec extends UnaryExecNode with
CodegenSupport {
s"""
| if ($countTerm < $limit) {
| $countTerm += 1;
+ | if ($countTerm == $limit) $stopEarly = true;
--- End diff --
Set stop early flag to true so we won't step into next element in iterator.
Otherwise, we still go to get next element from the iterator. So if the
limitation is 1, we will get 2 elements from the iterator.
Note: This won't cause real problem because we have an `if` to guard
against processing element.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
