Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573769
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -367,8 +410,16 @@ case class Remainder(left: Expression, right:
Expression)
}
@ExpressionDescription(
- usage = "_FUNC_(a, b) - Returns the positive modulo",
- extended = "> SELECT _FUNC_(10,3);\n 1")
+ usage = "_FUNC_(expr1, expr2) - Returns the positive modulo.",
+ extended = """
+ Arguments:
+ expr1 - a numeric expression.
+ expr2 - a numeric expression.
+
+ Examples:
+ > SELECT _FUNC_(10, 3);
--- End diff --
I think this definitely needs an example with a negative argument too, to
show for example that PMOD(-10,3) is 2 but -10 % 3 is -1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
