Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574029
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -603,8 +823,16 @@ case class Unhex(child: Expression) extends
UnaryExpression with ImplicitCastInp
////////////////////////////////////////////////////////////////////////////////////////////////////
@ExpressionDescription(
- usage = "_FUNC_(x,y) - Returns the arc tangent2.",
- extended = "> SELECT _FUNC_(0, 0);\n 0.0")
+ usage = "_FUNC_(expr1, expr2) - Returns the arc tangent2.",
--- End diff --
We should probably elaborate this a tiny bit, to say it's the arctangent of
two arguments, because there's no "tangent2" function. Really it means
(cribbing from wikipedia) the angle in radians between the positive x-axis of a
plane and the point given by the coordinates (expr1, expr2) on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
