Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15513
I mostly ran it by myself when I was in doubt so I guess it'd be mostly
okay. At least, one major issue was identified above, so I will definitely look
into this closely again.
BTW, there were comments about argument description (not about a typo but
semantic change),
https://github.com/apache/spark/pull/15513#discussion_r84824488,
https://github.com/apache/spark/pull/15513#discussion_r84824307,
https://github.com/apache/spark/pull/15513#discussion_r84613255,
https://github.com/apache/spark/pull/15513#discussion_r84597837,
https://github.com/apache/spark/pull/15513#discussion_r84597610,
https://github.com/apache/spark/pull/15513#discussion_r84613013 and
https://github.com/apache/spark/pull/15513#discussion_r85221940.
The valid ones are both
https://github.com/apache/spark/pull/15513#discussion_r84613013 and
https://github.com/apache/spark/pull/15513#discussion_r85221940 which I guess
only one is the major one (inappropriate type) and the other one is to take out
the type of decimal from numeric. I guess this does not imply that it has many
related issues about this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
