Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/15435
@sethah @jkbradley
Now I am considering elemating the `probabilityToPredictionUDF`,
There are some fussy problems about the `predictionCol` and the summary
class hierarchy....
currently, the base interface `LogisticRegressionSummary` do not have the
member `predictionCol`, which is needed in `MLOR summary`.
if I add the `predictionCol` into the base interface
`LogisticRegressionSummary` then `BinaryLogisticRegressionTrainingSummary` will
also need to be modified, it seems break API compatibility, should we avoid
such thing ?
And, whether should we make `BinaryLogisticRegressionTrainingSummary` be
the subclass of MLOR summary ? I would like let @jkbradley decide it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
