Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15435
@WeichenXu123 About breaking APIs: I'm OK adding predictionCol to
LogisticRegressionSummary, even though I agree it technically breaks a public
API:
* The traits are OK to change since they are sealed.
* The subclasses inheriting from the traits are public, but they all have
private constructors, so users cannot have extended them (except by using
hacks).
So I don't see a way this could break a non-hack use case, but let me know
if I'm not thinking of an edge case.
@zhengruifeng I'm OK refactoring to create a
MulticlassClassificationSummary (or MulticlassSummary?) now or later. Now does
sound better. Let's keep it ```private[ml]``` for now though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
